Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workiva Analysis Options v2 #946

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Workiva Analysis Options v2 #946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions tools/analyzer_plugin/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
include: package:workiva_analysis_options/v1.recommended.yaml

include: package:workiva_analysis_options/v2.yaml
analyzer:
exclude:
- playground/**
Expand All @@ -17,7 +16,6 @@ analyzer:
unused_import: info
import_of_legacy_library_into_null_safe: warning
implementation_imports: warning

# ignores from v1.recommended
prefer_interpolation_to_compose_strings: ignore
cascade_invocations: ignore
Expand All @@ -26,9 +24,3 @@ analyzer:
prefer_final_locals: ignore
# This is less readable in some cases, and isn't worth it.
join_return_with_assignment: ignore

linter:
rules:
- avoid_returning_null_for_future
- avoid_void_async
- implementation_imports
Loading