Code

FED-1885: Prop requiredness codemod#290

Code

Merged

rmconsole2-wf merged 91 commits intomasterWorkiva/over_react_codemod:masterfrom prop-requiredness-codemod-with-collectionWorkiva/over_react_codemod:prop-requiredness-codemod-with-collectionCopy head branch name to clipboardAug 10, 2024

+4,462-37

Commits

Commits on Jul 16, 2024

• Fix required hint util checking comments for subsequent nodes

  greglittlefield-wf

  committed
  dfdeacf

  Copy full SHA for dfdeacf

• Add constant for late hint

  greglittlefield-wf

  committed
  1ddf484

  Copy full SHA for 1ddf484

• First stab at prop requiredness codemod, using external data

  greglittlefield-wf

  committed
  1660af4

  Copy full SHA for 1660af4

• Update aggregated data format, consume updates

  greglittlefield-wf

  committed
  d1655e2

  Copy full SHA for d1655e2

• Factor in isPublic and skip rate, default to optional when no data

  greglittlefield-wf

  committed
  c07c785

  Copy full SHA for c07c785

• Improve reason strings

  greglittlefield-wf

  committed
  514a86b

  Copy full SHA for 514a86b

• Fix no-data case updating non-props

  greglittlefield-wf

  committed
  d28974d

  Copy full SHA for d28974d

Commits on Jul 18, 2024

• Add helpful todo for classes that were skipped

  greglittlefield-wf

  committed
  0f7d718

  Copy full SHA for 0f7d718

• Handle missing data case

  greglittlefield-wf

  committed
  c1b4df6

  Copy full SHA for c1b4df6

Commits on Jul 22, 2024

• Update args with recommender options

  greglittlefield-wf

  committed
  e4f4cdd

  Copy full SHA for e4f4cdd

• Re-sync aggregated data format

  greglittlefield-wf

  committed
  4ef3d4e

  Copy full SHA for 4ef3d4e

• Clarify message

  greglittlefield-wf

  committed
  b95b461

  Copy full SHA for b95b461

• Format

  greglittlefield-wf

  committed
  2e0247d

  Copy full SHA for 2e0247d

• Don't emit comments on individual props if the whole mixin was skipped

  greglittlefield-wf

  committed
  6bac8f9

  Copy full SHA for 6bac8f9

• Fix inverted boolean

  greglittlefield-wf

  committed
  f9b2c58

  Copy full SHA for f9b2c58

• Honor required prop annotations under flag

  greglittlefield-wf

  committed
  584e80b

  Copy full SHA for 584e80b

• Remove requiredProp annotations

  greglittlefield-wf

  committed
  60eb48f

  Copy full SHA for 60eb48f

• Make TODOs consistent

  greglittlefield-wf

  committed
  33b45c2

  Copy full SHA for 33b45c2

• Reorganize code

  greglittlefield-wf

  committed
  6a28031

  Copy full SHA for 6a28031

• Add copyright comments

  greglittlefield-wf

  committed
  f058c31

  Copy full SHA for f058c31

• Indicate copied files

  greglittlefield-wf

  committed
  6143eb9

  Copy full SHA for 6143eb9

• Support negatable args

  greglittlefield-wf

  committed
  4cbb5a6

  Copy full SHA for 4cbb5a6

• Add tests, fix bug in multi-arg option logic

  greglittlefield-wf

  committed
  fcf1e5d

  Copy full SHA for fcf1e5d

Commits on Jul 23, 2024

• Add required props data collection scripts

  greglittlefield-wf

  committed
  b144727

  Copy full SHA for b144727

• Format

  greglittlefield-wf

  committed
  6f94adc

  Copy full SHA for 6f94adc

• Add progress log back in

  greglittlefield-wf

  committed
  264f767

  Copy full SHA for 264f767

• Log package specs

  greglittlefield-wf

  committed
  f3ded7b

  Copy full SHA for f3ded7b

• Add output option to aggregate script

  greglittlefield-wf

  committed
  b6f18ed

  Copy full SHA for b6f18ed

Commits on Jul 24, 2024

• Allow hosted pub packages in collection script

  greglittlefield-wf

  committed
  d4719a7

  Copy full SHA for d4719a7

• Add help text to collect script

  greglittlefield-wf

  committed
  ff66c0c

  Copy full SHA for ff66c0c

• Add output directory arg to collect script

  greglittlefield-wf

  committed
  4f674f2

  Copy full SHA for 4f674f2

• Fail collect if no packages are specified

  greglittlefield-wf

  committed
  9cb548f

  Copy full SHA for 9cb548f

• Add some tests for required prop data collection and aggregation

  greglittlefield-wf

  committed
  803be69

  Copy full SHA for 803be69

• Fix output file not including package name

  greglittlefield-wf

  committed
  44eecb0

  Copy full SHA for 44eecb0

• Add tests for visibility data, fix indirectlyPublic visibility

  greglittlefield-wf

  committed
  3178106

  Copy full SHA for 3178106

Commits on Jul 30, 2024

• Add tests for props with usages in other packages

  greglittlefield-wf

  committed
  5e82b7d

  Copy full SHA for 5e82b7d

• Improve directory output

  greglittlefield-wf

  committed
  043f4c5

  Copy full SHA for 043f4c5

• Add test for non-factory usage filtering

  greglittlefield-wf

  committed
  7a69e89

  Copy full SHA for 7a69e89

• Fix test setup to use test_consuming_package

  greglittlefield-wf

  committed
  5821b84

  Copy full SHA for 5821b84

• Aggregate data by default in collect.dart

  greglittlefield-wf

  committed
  bdb3101

  Copy full SHA for bdb3101

• Include stdout on process failure

  greglittlefield-wf

  committed
  35bba9f

  Copy full SHA for 35bba9f

• Add end-to-end test for required props data collection and codemod

  greglittlefield-wf

  committed
  ccec045

  Copy full SHA for ccec045

• Make collect and codemod subcommands of a single executable

  greglittlefield-wf

  committed
  637fd19

  Copy full SHA for 637fd19

• Improve invocation line of help output

  greglittlefield-wf

  committed
  95f8014

  Copy full SHA for 95f8014

Commits on Jul 31, 2024

• Format

  greglittlefield-wf

  committed
  d6be7b5

  Copy full SHA for d6be7b5

• Add some usage instructions

  greglittlefield-wf

  committed
  bc5f078

  Copy full SHA for bc5f078

• Run pub get in codemod

  greglittlefield-wf

  committed
  935a191

  Copy full SHA for 935a191

• Rename flag

  greglittlefield-wf

  committed
  197e07d

  Copy full SHA for 197e07d

• Fix inverted boolean

  greglittlefield-wf

  committed
  4a930d6

  Copy full SHA for 4a930d6

• Add test coverage for required annotation logic and flag

  greglittlefield-wf

  committed
  361feb1

  Copy full SHA for 361feb1

• Clean up logging, add verbose flag

  greglittlefield-wf

  committed
  a6709c4

  Copy full SHA for a6709c4

• More logging tweaks

  greglittlefield-wf

  committed
  46dacc3

  Copy full SHA for 46dacc3

• Add coloring/formatting to logs

  greglittlefield-wf

  committed
  794f29e

  Copy full SHA for 794f29e

• Log more with verbose:true

  greglittlefield-wf

  committed
  09dad6d

  Copy full SHA for 09dad6d

• Fix inverted boolean

  greglittlefield-wf

  committed
  055502a

  Copy full SHA for 055502a

• Set up json_serializable, remove unused mockito whose builder was erroring

  greglittlefield-wf

  committed
  cd3c19c

  Copy full SHA for cd3c19c

• Add CI check for generated changes

  greglittlefield-wf

  committed
  f72e4e2

  Copy full SHA for f72e4e2

• Merge remote-tracking branch 'origin/master' into prop-requiredness-codemod-with-collection

  greglittlefield-wf

  committed
  52ff940

  Copy full SHA for 52ff940

• Format

  greglittlefield-wf

  committed
  e362ef7

  Copy full SHA for e362ef7

• Update test in response to formatting

  greglittlefield-wf

  committed
  b8726b9

  Copy full SHA for b8726b9

• Add missing dependency

  greglittlefield-wf

  committed
  8ad3aad

  Copy full SHA for 8ad3aad

Commits on Aug 1, 2024

• Merge branch 'fixes-and-cleanup' into prop-requiredness-codemod-with-collection

  greglittlefield-wf

  committed
  7c8a02a

  Copy full SHA for 7c8a02a

• Add tests for requiredness threshold options

  greglittlefield-wf

  committed
  1e55e90

  Copy full SHA for 1e55e90

• Add tests for skip arguments

  greglittlefield-wf

  committed
  c85d6bd

  Copy full SHA for c85d6bd

• Add some doc comments

  greglittlefield-wf

  committed
  f612d95

  Copy full SHA for f612d95

• Split out aggregation from its executable

  greglittlefield-wf

  committed
  bb959d1

  Copy full SHA for bb959d1

• Reorganize files

  greglittlefield-wf

  committed
  c898f84

  Copy full SHA for c898f84

• Reorganize/rename tests

  greglittlefield-wf

  committed
  bd6dbad

  Copy full SHA for bd6dbad

• Fix outdated name in pubspec

  greglittlefield-wf

  committed
  97556a0

  Copy full SHA for 97556a0

Commits on Aug 2, 2024

• Don't write individual results to files by default

  greglittlefield-wf

  committed
  d53328f

  Copy full SHA for d53328f

• Clean up temporary folder when we're done with it

  greglittlefield-wf

  committed
  d71085c

  Copy full SHA for d71085c

• Format

  greglittlefield-wf

  committed
  55565be

  Copy full SHA for 55565be

• Fix deletion of non-empty directory failing

  greglittlefield-wf

  committed
  db0f7e1

  Copy full SHA for db0f7e1

• Merge remote-tracking branch 'origin/master' into prop-requiredness-codemod-with-collection

  greglittlefield-wf

  committed
  c8f9d98

  Copy full SHA for c8f9d98

Commits on Aug 5, 2024

• Add copyright comments

  greglittlefield-wf

  committed
  134e15c

  Copy full SHA for 134e15c

• Update command descriptions

  greglittlefield-wf

  committed
  6ec1504

  Copy full SHA for 6ec1504

• Add and improve instructions

  greglittlefield-wf

  committed
  83a5dc3

  Copy full SHA for 83a5dc3

• Consolidate copies of get_all_props.dart

  greglittlefield-wf

  committed
  1bb0891

  Copy full SHA for 1bb0891

• Remove unused vendored file

  greglittlefield-wf

  committed
  f0f7d11

  Copy full SHA for f0f7d11

Commits on Aug 6, 2024

• Improve test coverage of required annotation tests

  Show description for ded4368
  greglittlefield-wf

  committed
  ded4368

  Copy full SHA for ded4368

• Align class name with file name and convention

  greglittlefield-wf

  committed
  0785240

  Copy full SHA for 0785240

• Add tests for existing hints, don't short-circuit on non-nullable hints

  greglittlefield-wf

  committed
  c223666

  Copy full SHA for c223666

• Add tests for existing hints, don't short-circuit on non-nullable hints

  greglittlefield-wf

  committed
  407ea41

  Copy full SHA for 407ea41

• Clean up .package-cache references, used same temp directory for Git

  greglittlefield-wf

  committed
  cbc86da

  Copy full SHA for cbc86da

• Use dart_dev for formatting so that we can exclude files

  greglittlefield-wf

  committed
  900191c

  Copy full SHA for 900191c

• Format

  greglittlefield-wf

  committed
  5bf1fc9

  Copy full SHA for 5bf1fc9

• Improve instructions, add note about mismatched versions

  greglittlefield-wf

  committed
  eda7140

  Copy full SHA for eda7140

• Indicate when using the latest version of a Pub package

  greglittlefield-wf

  committed
  50b6fc7

  Copy full SHA for 50b6fc7

• Display package versions from pubspec.lock, improve logs

  greglittlefield-wf

  committed
  dc5cb89

  Copy full SHA for dc5cb89

• Update instructions about package mismatches

  greglittlefield-wf

  committed
  db2dc7e

  Copy full SHA for db2dc7e

• Format

  greglittlefield-wf

  committed
  6393501

  Copy full SHA for 6393501