Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default index-relationships to true #104

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

matthewnitschke-wk
Copy link
Contributor

--index-relationships was originally added, and relied on due to thinking an unrelated issue in uploaded files was due to it

This pr removes the concept of --index-relationships as a flag, and just defaults its concept to true

There is no good reason to disable relationship indexing, and doing so results in inconsistent scip generation files

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk
Copy link
Contributor Author

QA +1

  • CI does indeed pass

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 4a3cddc into master Nov 9, 2023
7 checks passed
@rmconsole6-wk rmconsole6-wk deleted the default_index-relationships_to_true branch November 9, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants