FEA-2496: Fixed Cascade Indexing #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Comment on lines
-118
to
124
| if (node.parent is CompoundAssignmentExpression) { | ||
| final assignmentNode = node.parent as CompoundAssignmentExpression; | ||
| element = assignmentNode.readElement ?? assignmentNode.writeElement; | ||
| if (element == null) { | ||
| final assignmentExpr = | ||
| node.thisOrAncestorOfType<CompoundAssignmentExpression>(); | ||
| if (assignmentExpr == null) return; | ||
|
|
||
| element = assignmentExpr.readElement ?? assignmentExpr.writeElement; | ||
| } |
There was a problem hiding this comment.
Given the following dart code:
Foo()..value = 1;This is what the generated ast results in
Foo()..value = 1; (ExpressionStatement)
Foo()..value = 1 (CascadeExpression)
Foo() (MethodInvocation)
Foo (SimpleIdentifier)
() (ArgumentList)
..value = 1 (AssignmentExpression) <----- (extends from CompoundAssignmentExpression)
..value (PropertyAccess)
value (SimpleIdentifier)
1 (IntegerLiteral)
Given the above code, value (SimpleIdentifier) is the case that makes it to this conditional. If we refer to the ast, the parent of this element is PropertyAccess, not CompoundAssignmentExpression, which tells us this expression can occur at multiple depths, not just the parent
We can solve this by just searching for the closest node of the specific type, and treat that as the assignment expression we care about
matthewnitschke-wk
changed the title
kirkrichardson-wk
approved these changes
Sep 12, 2023
|
QA +1
|
|
🚀 @Workiva/release-management-p 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEA-2496
Closes #80