FEA-2796: Occurrence Diagnostics

[matthewnitschke-wk]

FEA-2796

Populates the diagnostics field on Occurrences: https://github.com/sourcegraph/scip/blob/main/scip.proto#L579 with data from the dart analyzer

Now that sourcegraph has fixed their gql provider for retrieving this diagnostic data: https://github.com/sourcegraph/sourcegraph/issues/56904, this data has become more helpful, and we should start populating it

[aviary2-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[evanweible-wf]

Should/could we update the snapshots to test the population of these diagnostics?

[matthewnitschke-wk]

@evanweible-wf

Should/could we update the snapshots to test the population of these diagnostics?

Unfortunately the snapshot command doesn't include diagnostics in what it writes

I considered writing my own (could even just be a json output thing), but its a bit more of a lift than I wanted to do for this PR. Happy to reconsider if you think that would be valuable

[evanweible-wf]

Nope that's fine with me - diagnostics are just extra, so as long as they don't break the generation in the first place, I'm fine not including them in the tests if it's a bigger lift

[matthewnitschke-wk]

Nope that's fine with me - diagnostics are just extra, so as long as they don't break the generation in the first place, I'm fine not including them in the tests if it's a bigger lift

👍 The existing snapshot tests, and my integration tests should cover that breakage case: https://github.com/Workiva/scip-dart/actions/runs/6598256582/job/17926049013?pr=94

I would like to get some tests to cover that though, I'll create a ticket for it so I dont forget

[matthewnitschke-wk]

Ticketed #98

[matthewnitschke-wk]

QA +1

• CI passes, and diagnostic data is additional, doesn't effect existing scip data

🚀 @Workiva/release-management-p 🚢

[rmconsole-wf]

+1 from RM