Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use crate::errors to send error #273

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Use crate::errors to send error #273

merged 3 commits into from
Nov 11, 2024

Conversation

mh-northlander
Copy link
Collaborator

fix #258.

  • use errors:SudachiError instead of pyo3::exceptions::*
  • always use wrap and wrap_ctx with module prefix e.g. errors::wrap

@mh-northlander mh-northlander merged commit 4e72d54 into develop Nov 11, 2024
8 checks passed
@mh-northlander mh-northlander deleted the refactor/258-py-consistent-error branch November 11, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuma-t kazuma-t kazuma-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise errors in a consistent manner (python)
2 participants
@mh-northlander @kazuma-t