Improvement: Delete unnecessary step in booking option creation #807

Wunderbyte-GmbH · Jan 18, 2025 · a7619c5 · a7619c5
1 parent 14cce30
commit a7619c5
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/tests/generator/lib.php b/tests/generator/lib.php
@@ -145,7 +145,7 @@ public function create_option($record = null) {
         // Finalizing object with required properties.
         $record->id = 0;
         $record->cmid = $booking->cmid;
-        $record->identifier = booking_option::create_truly_unique_option_identifier();
+        $record->identifier = $record->identifier ?? booking_option::create_truly_unique_option_identifier();
 
         $context = context_module::instance($record->cmid);
 
@@ -171,12 +171,12 @@ public function create_option($record = null) {
 
         // Create / save booking option(s).
         if ($record->id = booking_option::update($record, $context)) {
-            $record->optionid = $record->id;
+            //$record->optionid = $record->id;
 
             // Add price (via API).
-            $price = new Mod_bookingPrice('option', $record->id);
-            $price->set_data($record);
-            booking_option::update($record, $context);
+            // $price = new Mod_bookingPrice('option', $record->id);
+            // $price->set_data($record);
+            // booking_option::update($record, $context);
         }
 
         return $record;