Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SWASTIKA from AutoBuild templates #594

Closed
wants to merge 1 commit into from
Closed

Remove SWASTIKA from AutoBuild templates #594

wants to merge 1 commit into from

Conversation

trwnh
Copy link

@trwnh trwnh commented Mar 9, 2022

Description

This PR removes the SWASTIKA AutoBuild template from the defaults.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2022

CLA assistant check
All committers have signed the CLA.

@pcm1k
Copy link
Contributor

pcm1k commented Mar 11, 2022

Someone actually questioned Alexander01998 about this before:
https://www.reddit.com/r/WurstClient/comments/j2kijv/why_does_wurst_supply_a_swastika_template/

I don't necessarily agree or disagree with what he said. I'm just letting you know.

Copy link

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

  • They have been superseded by another pull request
  • They are out of scope or don't align with the project
  • They have become obsolete due to other changes
  • They have bugs or conflicts that won't be resolved

Copy link

coderabbitai bot commented Nov 22, 2023

Walkthrough

Walkthrough

The change involves the removal of a controversial template named "SWASTIKA" from the DefaultAutoBuildTemplates enum in a Java source file. This action likely reflects an effort to eliminate offensive content or adhere to community guidelines and standards.

Changes

File Path Change Summary
.../util/DefaultAutoBuildTemplates.java Removed the "SWASTIKA" template from the DefaultAutoBuildTemplates enum.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e7f60fe and da24930.
Files selected for processing (1)
  • src/main/java/net/wurstclient/util/DefaultAutoBuildTemplates.java (1 hunks)

@trwnh
Copy link
Author

trwnh commented Nov 22, 2023

No longer stale.

@TejasLamba2006
Copy link
Contributor

Damn this is my fault, I contributed and had this, "swastika" is my girl friend's name

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 2603857 and 3b1d36b.
Files selected for processing (1)
  • src/main/java/net/wurstclient/util/DefaultAutoBuildTemplates.java (1 hunks)
Additional comments: 2
src/main/java/net/wurstclient/util/DefaultAutoBuildTemplates.java (2)
  • 49-54: The removal of the SWASTIKA template from the DefaultAutoBuildTemplates enum appears to be complete as per the PR's objective. Ensure that there are no remaining references to the SWASTIKA template in the codebase that could cause errors or inconsistencies.

  • 49-54: Verify that the removal of the SWASTIKA template is also updated in the user documentation, if it was previously mentioned.

@Wurst-Imperium Wurst-Imperium locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants