Appendix G: update ZSM specification to include chip ID allocations for MIDI, additional clarifications #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or MIDI, additional clarifications
m00dawg
reviewed
Dec 13, 2024
| An alternative library with PCM support, ZSMKit, is avalable at: | ||
| https://github.com/mooinglemur/ZSMKit | ||
| A newer, more flexible, and more recently maintained library with PCM support, ZSMKit, is avalable at: | ||
| https://github.com/mooinglemur/ZSMKit/ | ||
|
|
||
| #### Current ZSM Revision: 1 |
There was a problem hiding this comment.
Would this be a situation where denotes a Revision 2?
m00dawg
approved these changes
Dec 13, 2024
|
Approved with one question on the ZSM version which doesn't need to block the PR (more tossing it out to make sure it was thought about rather than any actual suggestion on whether or not to bump the version) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to reflect what ZSMKit currently supports.