Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Local env fix on chains order #1040

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[bug] Local env fix on chains order #1040

merged 1 commit into from
Aug 22, 2024

Conversation

danielisaacgeslin
Copy link
Contributor

@danielisaacgeslin danielisaacgeslin commented Aug 22, 2024 •
edited
Loading

  • Fix on local env not using ordered chains form the api due to cancel requests by react's strict mode
  • Fix on local build scripts to use mainnet; old version of the script was missing the env var when running half of the process

local env using the correct network order

image

build script fix using mainnet networks

image

@danielisaacgeslin danielisaacgeslin self-assigned this Aug 22, 2024
@danielisaacgeslin danielisaacgeslin merged commit a8a0e74 into main Aug 22, 2024
21 checks passed
@sebastianscatularo sebastianscatularo deleted the bug/local-env-chain-order branch August 30, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianscatularo sebastianscatularo sebastianscatularo approved these changes

@yuli-ferna yuli-ferna Awaiting requested review from yuli-ferna

Assignees

@danielisaacgeslin danielisaacgeslin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielisaacgeslin @sebastianscatularo