Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add integrity checks for wc loader #602

Merged
merged 4 commits into from
Dec 15, 2023
Merged

add integrity checks for wc loader #602

merged 4 commits into from
Dec 15, 2023

Conversation

sebastianscatularo
Copy link
Contributor

No description provided.

M-Picco
M-Picco approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@M-Picco M-Picco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: any reason for picking sha384 over sha512?

apps/connect/src/components/ConnectLoader.tsx Outdated Show resolved Hide resolved
@sebastianscatularo
Copy link
Contributor Author

Out of curiosity: any reason for picking sha384 over sha512?

sha384 is not vulnerable to length extension attacks, and is cheaper to calculate than sha512, and as far I could read around internet, some SHA512 version could also be vulnerable to extension attacks

@sebastianscatularo sebastianscatularo merged commit 5c39519 into main Dec 15, 2023
18 checks passed
@sebastianscatularo sebastianscatularo deleted the feat/add-integrity-check branch December 17, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-Picco M-Picco M-Picco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianscatularo @M-Picco