Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support new NTT Tokens in Portal #911

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Add Support new NTT Tokens in Portal #911

merged 9 commits into from
Jul 30, 2024

Conversation

yuli-ferna
Copy link
Contributor

@yuli-ferna yuli-ferna commented Jul 4, 2024 •
edited
Loading

Issue: https://github.com/XLabs/portal-bridge-ui-issues/issues/87

Yaku

Captura de pantalla 2024-07-29 a las 10 19 16 a m

WeatherXM

Captura de pantalla 2024-07-29 a las 10 18 52 a m

Fantom USD.e

Captura de pantalla 2024-07-29 a las 10 20 07 a m

JitoSOL

Captura de pantalla 2024-07-29 a las 10 20 38 a m

Swissborg

Captura de pantalla 2024-07-29 a las 10 21 10 a m

Stakewise

Captura de pantalla 2024-07-29 a las 10 24 25 a m

Agora

Captura de pantalla 2024-07-29 a las 10 25 06 a m

XBorg

Captura de pantalla 2024-07-29 a las 10 25 32 a m

Cheese

Captura de pantalla 2024-07-29 a las 10 25 51 a m

@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 4, 2024 20:22 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 4, 2024 20:22 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 4, 2024 20:22 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 4, 2024 20:22 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 4, 2024 20:22 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 4, 2024 20:22 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 4, 2024 20:22 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 4, 2024 20:22 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 4, 2024 20:29 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 4, 2024 20:31 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 8, 2024 20:44 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 8, 2024 20:44 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 8, 2024 20:44 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 8, 2024 20:44 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 8, 2024 20:44 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 8, 2024 20:44 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 8, 2024 20:44 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 8, 2024 20:44 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 8, 2024 20:51 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 8, 2024 20:52 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 9, 2024 17:36 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 9, 2024 17:36 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 9, 2024 17:36 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 9, 2024 17:36 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 9, 2024 17:36 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 9, 2024 17:36 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 9, 2024 17:36 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 29, 2024 14:45 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 29, 2024 14:45 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 29, 2024 19:31 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 29, 2024 19:31 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 29, 2024 19:31 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 29, 2024 19:31 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 29, 2024 19:31 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 29, 2024 19:31 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 29, 2024 19:31 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 29, 2024 19:31 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 29, 2024 19:38 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 29, 2024 19:40 — with GitHub Actions Inactive
sebastianscatularo
sebastianscatularo requested changes Jul 29, 2024
View reviewed changes
apps/connect/src/env/token-bridge.mainnet.ts Outdated
@@ -54,7 +54,8 @@ export const ENV: Env = {
icon: "https://assets.coingecko.com/coins/images/35958/standard/etherfi.jpeg?1710254562",
coinGeckoId: "ether-fi",
decimals: {
default: 18,
default: 8,
Ethereum: 18,
Arbitrum: 18,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arbitrum desn't exist as Conetxt ;)

sebastianscatularo
sebastianscatularo reviewed Jul 29, 2024
View reviewed changes
apps/connect/src/env/token-bridge.mainnet.ts Outdated
coinGeckoId: "yaku",
decimals: {
default: 8,
Ethereum: 9,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ethereum shouldn't be necessary here

@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 30, 2024 13:08 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 30, 2024 13:08 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 30, 2024 13:08 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 30, 2024 13:08 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 30, 2024 13:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 30, 2024 13:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 30, 2024 13:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 30, 2024 13:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet July 30, 2024 13:16 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview July 30, 2024 13:17 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna merged commit 35ac4a0 into main Jul 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielisaacgeslin danielisaacgeslin danielisaacgeslin approved these changes

@sebastianscatularo sebastianscatularo sebastianscatularo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuli-ferna @sebastianscatularo @danielisaacgeslin