Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugs] Portal bridge transfer route has empty content #922

Merged
merged 2 commits into from
Jul 12, 2024
Merged

[bugs] Portal bridge transfer route has empty content #922

merged 2 commits into from
Jul 12, 2024

Conversation

danielisaacgeslin
Copy link
Contributor

@danielisaacgeslin danielisaacgeslin commented Jul 11, 2024 •
edited
Loading

[bugs] Portal bridge transfer route has empty content

  • Fixed router to use a wildcard for connect after trying to match the privacy policy route
  • Change on the useQueryParams to allow for qs after url hashes (/#/transfer?qs...)

https://preview.portalbridge.com/d656da0029/#/transfer?sourceChain=bsc&targetChain=arbitrum

image image image image

@danielisaacgeslin danielisaacgeslin merged commit 654ba4e into main Jul 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianscatularo sebastianscatularo sebastianscatularo approved these changes

@yuli-ferna yuli-ferna Awaiting requested review from yuli-ferna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielisaacgeslin @sebastianscatularo