Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic testing coverage #931

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Add basic testing coverage #931

merged 8 commits into from
Jul 16, 2024

Conversation

danielisaacgeslin
Copy link
Contributor

@danielisaacgeslin danielisaacgeslin commented Jul 16, 2024 •
edited
Loading

  • Add coverage report
  • Add testing baseline testing for hooks, etc
  • Some cleanup/refactor after affected code got tested

image

@danielisaacgeslin danielisaacgeslin marked this pull request as ready for review July 16, 2024 13:24
sebastianscatularo
sebastianscatularo approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@sebastianscatularo sebastianscatularo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 lgtm

@danielisaacgeslin danielisaacgeslin merged commit 103020b into main Jul 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianscatularo sebastianscatularo sebastianscatularo approved these changes

@yuli-ferna yuli-ferna Awaiting requested review from yuli-ferna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielisaacgeslin @sebastianscatularo