PHP 8.0: @ Error Suppression operator does not silent fatal errors

XOOPS · Oct 2, 2023 · d2a1c12 · d2a1c12
1 parent c52381b
commit d2a1c12
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/FilterInput.php b/src/FilterInput.php
@@ -214,14 +214,14 @@ public function cleanVar($source, $type = 'string')
             case 'INTEGER':
                 // Only use the first integer value
                 preg_match('/-?\d+/', (string) $source, $matches);
-                $result = @ (int) $matches[0];
+                $result = isset($matches[0]) ? (int) $matches[0] : 0;
                 break;
 
             case 'FLOAT':
             case 'DOUBLE':
                 // Only use the first floating point value
                 preg_match('/-?\d+(\.\d+)?/', (string) $source, $matches);
-                $result = @ (float) $matches[0];
+                $result = isset($matches[0]) ? (float) $matches[0] : 0;
                 break;
 
             case 'BOOL':
@@ -259,7 +259,7 @@ public function cleanVar($source, $type = 'string')
                 $source = trim((string) $source);
                 $pattern = '/^([-_\.\/A-Z0-9=&%?~]+)(.*)$/i';
                 preg_match($pattern, $source, $matches);
-                $result = @ (string) $matches[1];
+                $result = isset($matches[1]) ? (string) $matches[1] : '';
                 break;
 
             case 'USERNAME':