Skip to content

Commit

Permalink
fix: add no lint to ignore clang-tidy (#1660)
Browse files Browse the repository at this point in the history
  • Loading branch information
PeterChen13579 authored Sep 21, 2024
1 parent c409f8b commit c8e3da6
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions src/util/newconfig/ConfigConstraints.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class Constraint {
// see here for more info:
// https://stackoverflow.com/questions/72835571/constexpr-c-error-destructor-used-before-its-definition
// https://godbolt.org/z/eMdWThaMY
constexpr virtual ~Constraint() noexcept = default;
constexpr virtual ~Constraint() noexcept {}; // NOLINT(google-default-destructor)

/**
* @brief Check if the value meets the specific constraint.
Expand Down Expand Up @@ -156,7 +156,8 @@ class Constraint {
class PortConstraint final : public Constraint {
public:
constexpr ~PortConstraint() override
= default;
{
} // NOLINT(google-default-destructor)

private:
/**
Expand Down Expand Up @@ -187,7 +188,8 @@ class PortConstraint final : public Constraint {
class ValidIPConstraint final : public Constraint {
public:
constexpr ~ValidIPConstraint() override
= default;
{
} // NOLINT(google-default-destructor)

private:
/**
Expand Down Expand Up @@ -228,7 +230,8 @@ class OneOf final : public Constraint {
}

constexpr ~OneOf() override
= default;
{
} // NOLINT(google-default-destructor)

private:
/**
Expand Down Expand Up @@ -283,7 +286,8 @@ class NumberValueConstraint final : public Constraint {
}

constexpr ~NumberValueConstraint() override
= default;
{
} // NOLINT(google-default-destructor)

private:
/**
Expand Down Expand Up @@ -325,7 +329,8 @@ class NumberValueConstraint final : public Constraint {
class PositiveDouble final : public Constraint {
public:
constexpr ~PositiveDouble() override
= default;
{
} // NOLINT(google-default-destructor)

private:
/**
Expand Down

0 comments on commit c8e3da6

Please sign in to comment.