tidy up

src/migration/README.md

@@ -40,7 +40,7 @@ A migrator satisfies the `MigratorSpec`(Spec.hpp) concept.
 
 It contains:
 
--  A `name` which will be used to identify the migrator. User will refer this migrator in command-line tool by this name. The name needs to be different with other migrators, otherwise a compiler error will be raised.
+-  A `name` which will be used to identify the migrator. User will refer this migrator in command-line tool by this name. The name needs to be different with other migrators, otherwise a compilation error will be raised.
 
 -  A `description` which is the detail information of the migrator.
 

src/migration/Spec.hpp

@@ -37,6 +37,9 @@ concept MigratorSpec = requires(std::shared_ptr<Backend> const& backend, util::C
     // Check that 'name' exists and is a string
     { T::name } -> std::convertible_to<std::string>;
 
+    // Check that 'description' exists and is a string
+    { T::description } -> std::convertible_to<std::string>;
+
     // Check that the migrator specifies the backend type it supports
     typename T::Backend;
 

tests/common/util/MockMigrationBackend.hpp

@@ -31,8 +31,6 @@
 
 #include <string>
 
-using namespace data;
-
 struct MockMigrationBackend : public MockBackend {
     MockMigrationBackend(util::Config) : MockBackend(util::Config{})
     {

tests/common/util/StringUtils.cpp

@@ -25,9 +25,7 @@
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/protocol/LedgerHeader.h>
 
-#include <sstream>
 #include <string>
-#include <vector>
 
 std::string
 hexStringToBinaryString(std::string const& hex)
@@ -57,18 +55,3 @@ ledgerHeaderToBinaryString(ripple::LedgerHeader const& info)
 
     return strBlob;
 };
-
-std::vector<std::string>
-splitLines(std::string const& rawlines, char delimiter)
-{
-    std::vector<std::string> lines;
-    std::istringstream stream(rawlines);
-    std::string line;
-
-    // Read each line and add it to the vector
-    while (std::getline(stream, line, delimiter)) {
-        lines.push_back(line);
-    }
-
-    return lines;
-}

tests/common/util/StringUtils.hpp

@@ -33,6 +33,3 @@ binaryStringToUint256(std::string const& bin);
 
 std::string
 ledgerHeaderToBinaryString(ripple::LedgerHeader const& info);
-
-std::vector<std::string>
-splitLines(std::string const& rawlines, char delimiter);

tests/unit/CMakeLists.txt

@@ -50,13 +50,13 @@ target_sources(
           Playground.cpp
           ProfilerTests.cpp
           # Migration
+          migration/cassandra/FullTableScannerTests.cpp
+          migration/cassandra/SpecTests.cpp
           migration/MigratorRegisterTests.cpp
           migration/MigratorStatusTests.cpp
           migration/MigrationManagerBaseTests.cpp
           migration/MigrationManagerFactoryTests.cpp
           migration/SpecTests.cpp
-          migration/cassandra/FullTableScannerTests.cpp
-          migration/cassandra/SpecTests.cpp
           # RPC
           rpc/APIVersionTests.cpp
           rpc/BaseTests.cpp