-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extraction basics #1733
feat: Extraction basics #1733
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1733 +/- ##
===========================================
+ Coverage 71.94% 72.07% +0.13%
===========================================
Files 283 287 +4
Lines 12061 12157 +96
Branches 6141 6177 +36
===========================================
+ Hits 8677 8762 +85
- Misses 1782 1785 +3
- Partials 1602 1610 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like more structured 💯
I left some comments about makeExtractor and uint256ToString
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !!!!
For #1596
This PR implements the transformation from PB to our internal models to be used in ETL ng.