Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extraction basics #1733

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Conversation

godexsoft
Copy link
Collaborator

For #1596

This PR implements the transformation from PB to our internal models to be used in ETL ng.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 88.54167% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (a4b3877) to head (18affb4).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/etlng/impl/Extraction.cpp 88.04% 3 Missing and 8 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1733      +/-   ##
===========================================
+ Coverage    71.94%   72.07%   +0.13%     
===========================================
  Files          283      287       +4     
  Lines        12061    12157      +96     
  Branches      6141     6177      +36     
===========================================
+ Hits          8677     8762      +85     
- Misses        1782     1785       +3     
- Partials      1602     1610       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like more structured 💯
I left some comments about makeExtractor and uint256ToString

Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !!!!

@godexsoft godexsoft merged commit 815dfd6 into XRPLF:develop Nov 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants