Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: credential error message bug #1738

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

PeterChen13579
Copy link
Collaborator

fixes #1737

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.10%. Comparing base (815dfd6) to head (56eb8cf).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1738      +/-   ##
===========================================
+ Coverage    72.08%   72.10%   +0.02%     
===========================================
  Files          287      287              
  Lines        12157    12160       +3     
  Branches      6177     6177              
===========================================
+ Hits          8763     8768       +5     
  Misses        1783     1783              
+ Partials      1611     1609       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterChen13579 assuming that the output needs to match the same handler in rippled, don't they have an error code we can reuse in the latest libxrpl for this?

@godexsoft godexsoft self-requested a review November 18, 2024 16:07
@godexsoft godexsoft merged commit 229ba69 into XRPLF:develop Nov 18, 2024
17 checks passed
godexsoft pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants