Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GrpcSource for ETL ng #1745

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

godexsoft
Copy link
Collaborator

For #1596 and #1597

This is a slightly modified version of the existing GrpcSource and a renamed AsyncCallData.
Instead of writing to the database directly from the async downloader we introduce an interface for observing the initial ledger load which allows us to separate the downloading from the writing.

The included unit tests are inspired by the existing etl/GrpcSourceTests and use the same approach with the mocked gRPC server.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 73.05389% with 45 lines in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (9dc322f) to head (0594ecb).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/etlng/impl/AsyncGrpcCall.cpp 72.00% 10 Missing and 11 partials ⚠️
src/etlng/impl/GrpcSource.cpp 71.64% 8 Missing and 11 partials ⚠️
src/web/Resolver.cpp 82.60% 2 Missing and 2 partials ⚠️
src/web/dosguard/WhitelistHandler.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1745      +/-   ##
===========================================
- Coverage    71.71%   71.71%   -0.01%     
===========================================
  Files          292      295       +3     
  Lines        12487    12649     +162     
  Branches      6359     6471     +112     
===========================================
+ Hits          8955     9071     +116     
- Misses        1848     1870      +22     
- Partials      1684     1708      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

src/etlng/impl/GrpcSource.cpp Outdated Show resolved Hide resolved
src/etlng/impl/GrpcSource.cpp Show resolved Hide resolved
tests/unit/etlng/GrpcSourceTests.cpp Outdated Show resolved Hide resolved
@godexsoft godexsoft marked this pull request as ready for review November 21, 2024 16:31
@godexsoft godexsoft requested a review from kuznetsss November 21, 2024 16:39
Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@godexsoft godexsoft merged commit 6af8636 into XRPLF:develop Nov 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants