-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GrpcSource for ETL ng #1745
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1745 +/- ##
===========================================
- Coverage 71.71% 71.71% -0.01%
===========================================
Files 292 295 +3
Lines 12487 12649 +162
Branches 6359 6471 +112
===========================================
+ Hits 8955 9071 +116
- Misses 1848 1870 +22
- Partials 1684 1708 +24 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
For #1596 and #1597
This is a slightly modified version of the existing
GrpcSource
and a renamedAsyncCallData
.Instead of writing to the database directly from the async downloader we introduce an interface for observing the initial ledger load which allows us to separate the downloading from the writing.
The included unit tests are inspired by the existing
etl/GrpcSourceTests
and use the same approach with the mocked gRPC server.