Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check ledger range in every handler #1755

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

PeterChen13579
Copy link
Collaborator

fixes #1565

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.69%. Comparing base (63c80f2) to head (e05c5bc).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/rpc/common/impl/HandlerProvider.cpp 0.00% 1 Missing ⚠️
src/rpc/handlers/ServerInfo.hpp 0.00% 0 Missing and 1 partial ⚠️
src/rpc/handlers/Subscribe.cpp 50.00% 0 Missing and 1 partial ⚠️
src/rpc/handlers/Tx.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1755      +/-   ##
===========================================
+ Coverage    71.65%   71.69%   +0.03%     
===========================================
  Files          295      295              
  Lines        12649    12679      +30     
  Branches      6471     6500      +29     
===========================================
+ Hits          9064     9090      +26     
  Misses        1872     1872              
- Partials      1713     1717       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not every handler. I did not see subscribe unsubscribe, they are immune?

@PeterChen13579 PeterChen13579 merged commit fe4f95d into XRPLF:develop Nov 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check ledger range in every handler
4 participants