Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migration framework #1768

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

feat: Migration framework #1768

wants to merge 10 commits into from
+4,287 −13

Conversation

cindyyan317
Copy link
Collaborator

This PR implemented the migration framework, which contains the command line interface to execute migration and helps to migrate data easily.
Please read README.md for more information about this framework.

@cindyyan317 cindyyan317 changed the title Migration framework feat: Migration framework Dec 3, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 32.37705% with 165 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (b53cfd0) to head (17f8d6b).

Files with missing lines Patch % Lines
src/migration/MigrationApplication.cpp 0.00% 37 Missing ⚠️
.../migration/cassandra/CassandraMigrationBackend.hpp 0.00% 25 Missing ⚠️
src/migration/impl/MigratorsRegister.hpp 51.28% 9 Missing and 10 partials ⚠️
src/migration/cassandra/impl/FullTableScanner.hpp 63.04% 1 Missing and 16 partials ⚠️
src/migration/impl/MigrationManagerFactory.cpp 28.57% 6 Missing and 4 partials ⚠️
src/main/Main.cpp 0.00% 9 Missing ⚠️
src/migration/cassandra/impl/ObjectsAdapter.cpp 0.00% 8 Missing ⚠️
...ion/cassandra/impl/FullTableScannerAdapterBase.hpp 0.00% 7 Missing ⚠️
...c/migration/cassandra/impl/TransactionsAdapter.cpp 0.00% 7 Missing ⚠️
src/app/CliArgs.cpp 14.28% 5 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1768      +/-   ##
===========================================
- Coverage    71.96%   71.21%   -0.75%     
===========================================
  Files          297      313      +16     
  Lines        12775    13019     +244     
  Branches      6548     6662     +114     
===========================================
+ Hits          9193     9271      +78     
- Misses        1845     1977     +132     
- Partials      1737     1771      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

godexsoft
godexsoft requested changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nice system but needs some polish 🔢 👍

Among other things it would be nice to add some static_assert tests for the introduced concepts, come up with better names for several functions and move some/majority of the code to impl.

src/app/CliArgs.cpp Outdated Show resolved Hide resolved
src/data/README.md Outdated Show resolved Hide resolved
src/data/cassandra/Schema.hpp Outdated Show resolved Hide resolved
src/data/cassandra/Schema.hpp Outdated Show resolved Hide resolved
src/main/Main.cpp Show resolved Hide resolved
src/migration/cassandra/CassandraMigrationBackend.hpp Outdated Show resolved Hide resolved
src/migration/cassandra/CassandraMigrationSchema.hpp Outdated Show resolved Hide resolved
src/migration/cassandra/CassandraMigrationSchema.hpp Outdated Show resolved Hide resolved
src/migration/cassandra/CassandraMigrationSchema.hpp Outdated Show resolved Hide resolved
src/migration/cassandra/FullTableScanner.hpp Outdated Show resolved Hide resolved
kuznetsss
kuznetsss reviewed Dec 6, 2024
View reviewed changes
src/CMakeLists.txt Show resolved Hide resolved
src/data/CassandraBackend.hpp Outdated Show resolved Hide resolved
src/data/cassandra/Types.hpp Outdated Show resolved Hide resolved
src/main/Main.cpp Show resolved Hide resolved
src/migration/MigrationApplication.cpp Outdated Show resolved Hide resolved
src/migration/cassandra/FullTableScanner.hpp Outdated Show resolved Hide resolved
src/migration/cassandra/FullTableScanner.hpp Outdated Show resolved Hide resolved
src/util/Concepts.hpp Outdated Show resolved Hide resolved
tests/integration/migration/cassandra/CassandraMigrationManagerTests.cpp Outdated Show resolved Hide resolved
tests/integration/migration/cassandra/CassandraMigrationManagerTests.cpp Show resolved Hide resolved
@cindyyan317 cindyyan317 force-pushed the migration2 branch 3 times, most recently from 0c954ee to 5e3a3ac Compare December 13, 2024 11:17
@cindyyan317
draft
d0dded7 
tidy up

Update document

update adapter

+ document

Add document

nits
@cindyyan317
Fix doc
fcb0fb4
@cindyyan317
Fix doc
ad42206
@cindyyan317
try fix doc
47b981a
@cindyyan317
update doc
6803ae1
@cindyyan317
Fix comments
17f6db7
kuznetsss
kuznetsss previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

godexsoft
godexsoft requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found more small things 🔢

src/app/CliArgs.cpp Outdated Show resolved Hide resolved
src/data/BackendInterface.hpp Outdated Show resolved Hide resolved
src/data/cassandra/impl/Statement.hpp Outdated Show resolved Hide resolved
src/migration/MigratiorStatus.hpp Outdated Show resolved Hide resolved
src/migration/MigratiorStatus.hpp Show resolved Hide resolved
tests/integration/migration/cassandra/ExampleObjectsMigrator.cpp Outdated Show resolved Hide resolved
tests/integration/util/CassandraDBHelper.cpp Outdated Show resolved Hide resolved
tests/unit/migration/MigrationManagerBaseTests.cpp Outdated Show resolved Hide resolved
tests/unit/migration/MigratorRegisterTests.cpp Outdated Show resolved Hide resolved
tests/unit/migration/cassandra/FullTableScannerTests.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godexsoft godexsoft godexsoft requested changes

@kuznetsss kuznetsss kuznetsss left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cindyyan317 @godexsoft @kuznetsss