Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve Repeat implementation #1775

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

kuznetsss
Copy link
Collaborator

No description provided.

@kuznetsss kuznetsss requested a review from godexsoft December 10, 2024 15:29
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (c41399e) to head (45fe594).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/util/Repeat.hpp 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1775      +/-   ##
===========================================
- Coverage    71.96%   71.96%   -0.01%     
===========================================
  Files          297      297              
  Lines        12772    12775       +3     
  Branches      6545     6548       +3     
===========================================
+ Hits          9192     9193       +1     
  Misses        1845     1845              
- Partials      1735     1737       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kuznetsss kuznetsss merged commit b53cfd0 into XRPLF:develop Dec 11, 2024
17 checks passed
@kuznetsss kuznetsss deleted the Improve_Repeat branch December 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants