Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes button isn't obvious #524

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions Xcodes/Frontend/InfoPane/ReleaseDateView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,16 @@ struct ReleaseDateView: View {
if let date = date {

VStack(alignment: .leading) {
HStack {
Text("ReleaseDate")
.font(.headline)
Spacer()
if let url {
ReleaseNotesView(url: url)
}
}
Text("ReleaseDate")
.font(.headline)

Text("\(date, style: .date)")
.font(.subheadline)

if let url {
ReleaseNotesView(url: url)
.padding(.top, 2)
}
}


Expand Down
5 changes: 2 additions & 3 deletions Xcodes/Frontend/InfoPane/ReleaseNotesView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@ struct ReleaseNotesView: View {
var body: some View {
if let url = url {
Button(action: { openURL(url) }) {
Image(systemName: "link.circle.fill")
.font(.title)
Text("ReleaseNotes")
.font(.callout)
}
.buttonStyle(.plain)
.contextMenu(menuItems: {
CopyReleaseNoteButton(url: url)
})
Expand Down
52 changes: 52 additions & 0 deletions Xcodes/Resources/Localizable.xcstrings
Original file line number Diff line number Diff line change
Expand Up @@ -16516,6 +16516,58 @@
}
}
},
"ReleaseNotes" : {
"localizations" : {
"ca" : {
"stringUnit" : {
"state" : "translated",
"value" : "Notes de la versió"
}
},
"de" : {
"stringUnit" : {
"state" : "translated",
"value" : "Release-Notes"
}
},
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Release Notes"
}
},
"es" : {
"stringUnit" : {
"state" : "translated",
"value" : "Notas del Lanzamiento"
}
},
"fr" : {
"stringUnit" : {
"state" : "translated",
"value" : "Notes de Mise á Jour"
}
},
"it" : {
"stringUnit" : {
"state" : "translated",
"value" : "Note di Rilascio"
}
},
"nl" : {
"stringUnit" : {
"state" : "translated",
"value" : "Release Notes"
}
},
"pt-BR" : {
"stringUnit" : {
"state" : "translated",
"value" : "Notas de Lançamento"
}
}
}
},
"ReleaseNotes.help" : {
"localizations" : {
"ca" : {
Expand Down