Improve error message when using xcodes select without Xcode installed
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngimelliUW
force-pushed
the
feature/350/xcodes-select-error-message-improvement-without-xcode-installed
branch
from
99152cf to
922007b
Compare
ngimelliUW
changed the title
xcodes select without Xcode installxcodes select without Xcode installed
pjtnt11
approved these changes
Mar 4, 2024
ngimelliUW
force-pushed
the
feature/350/xcodes-select-error-message-improvement-without-xcode-installed
branch
from
922007b to
93c3e77
Compare
ngimelliUW
force-pushed
the
feature/350/xcodes-select-error-message-improvement-without-xcode-installed
branch
from
93c3e77 to
9b10bb0
Compare
|
@MattKiazyk can you please review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary This PR improves the error message given when running
xcodes selectwithout any Xcode version installed.Previously, the error message was:
"Not a valid number. Expecting a whole number between 1-0", but ____ was given. Now, if no Xcode is installed, it will sayNo Xcode version installed. Please run 'xcodes install' and try againScreenshots