-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SRP Apple login #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add any tests for this new flow? Similar to those in the Xcodes.app repo
@MattKiazyk , I've run this locally to download the 16.2 Beta and it worked for me Here's what I did:
I think this should have tested the flow that you changed, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix is working for me and using the SRP login! Thanks @MattKiazyk
Edit: I have not validated the implementation aside from checking that it works. Happy to compare to a reference implementation or other documentation if you have a link/resource for me to compare to though!
Apple switched up their login to now use a Secure Remote Password type of algorithm. This add support for it, so a user can login properly.
Fixes #388