-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search suggestions with proxy to bypass cors #65
Conversation
+ Search Recommendation - Some unwanted things removed
@XengShi I don't use brave can you check this pull. |
it should work in chrome as normal without enabling proxy @itz-rj-here |
This comment was marked as off-topic.
This comment was marked as off-topic.
@Minuga-RC can you check your extensions menu and check if you are also having this issue? |
I guess I'm the only one who is getting this error. |
what are you exactly trying to do there why is it showing my proxy repo as the context? |
I just saw the repository. Nothing else. |
umm nothing proxy dont need access to the time or date |
Thats strange. |
@itz-rj-here can u check if the same error appears in the main version? |
yup. just a min. |
This comment was marked as off-topic.
This comment was marked as off-topic.
I'm thinking to take some help from chatgpt. Cause none of us is understanding the issue. 😂 |
I don't think this is my fault |
anyway does the search suggestions works to you without a proxy? @itz-rj-here |
I can understand. |
I actually do not use proxy much but i can check it real quick. |
yea you can enable Search Suggestions in settings |
This comment was marked as off-topic.
This comment was marked as off-topic.
alr I will let u do that xd |
yup. :) |
Forget it its not even your work. do this one. |
oh I can fix that |
@MestreWalla did it if im not wrong. |
Yup found it. #48 |
You are doing the coding thingy and I'm testing your code thingy. Also eating and doing my assignment. :) |
I just finished eating thats why I took some time to reply lol |
@itz-rj-here fixed the issue |
Great work @Minuga-RC. You should rest now, you did a lot of work for 2-3 days. I will not disturb you now. As everything is fixed. Thanks for the contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now need to List all the changes where made here.
I made the translation system, but I didn't understand this language, if the Google buttons and others also have to be translated into some languages, I can implement the translation for them, but I'll let you insert the translation so I only understand English and Portuguese, I can't know if Google translated it correctly. |
Added search suggestions with proxy to bypass CORS errors (user can host their own proxy). |
I understand. It can be translated into other languages, actually. It's like changing the language, but the sound of the translated Google name will be the same as the English Google name. Thats all. @MestreWalla. |
We will talk about the translation thing in the #68. |
@XengShi Requesting for review. |
@itz-rj-here I removed a not used style |
Hmm. This thing is not being used. Great. 3 Lines of code is being cleaned up. 😂 |
Some times I think that XengShi is a baby boss. 😂 |
lol |
@XengShi is there is anything else that I can add/change? |
Excellent work, @Minuga-RC! Much love to you ♥. However, the issue persists, similar to the one we had with dark mode earlier. The proxy warning appears with every reload. Kindly fix that as well. The warning or disclaimer should only appear on the first load of the extension or after resetting the extension settings. |
Umm it does only appear in the first load tho I made it like that |
In [Chrome on Windows] it appears everytime after reloading or opening newTab but in Firefox it is working fine, strange! |
Wait, i didn’t see that issue. Only when i reset the settings and first load the settings it shows. But it doesn’t show on every single load. |
@XengShi so you need to press Ok to the alert so it records it in the local storage |
Yeah, it's working fine. I was just clicking outside the dialog. Thanks for responding. |
Added a proxy to bypass CORS errors (user can host there own proxy)
Added a option to disable/enable Search suggestions and Proxy
I added a proxy option because in some browsers like brave CORS errors appear but Proxy is turned off by default