Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search suggestions with proxy to bypass cors #65

Merged
merged 12 commits into from
Oct 17, 2024
Merged

Conversation

Minuga-RC
Copy link
Contributor

@Minuga-RC Minuga-RC commented Oct 16, 2024

Added a proxy to bypass CORS errors (user can host there own proxy)
Added a option to disable/enable Search suggestions and Proxy

I added a proxy option because in some browsers like brave CORS errors appear but Proxy is turned off by default

@itz-rj-here
Copy link
Contributor

@XengShi I don't use brave can you check this pull.

@Minuga-RC
Copy link
Contributor Author

@XengShi I don't use brave can you check this pull.

it should work in chrome as normal without enabling proxy @itz-rj-here

script.js Outdated Show resolved Hide resolved
@itz-rj-here

This comment was marked as off-topic.

@itz-rj-here
Copy link
Contributor

@Minuga-RC can you check your extensions menu and check if you are also having this issue?

@itz-rj-here
Copy link
Contributor

I guess I'm the only one who is getting this error.

@Minuga-RC
Copy link
Contributor Author

Minuga-RC commented Oct 16, 2024

heck if you are also having this issue

I am not getting that error
image
this error is cuz I dont have the localhost proxy running atm

@Minuga-RC
Copy link
Contributor Author

I guess I'm the only one who is getting this error.

what are you exactly trying to do there why is it showing my proxy repo as the context?

@itz-rj-here
Copy link
Contributor

I just saw the repository. Nothing else.
Wait its not even your fault. Its the month configuration code line. What is the connection with the proxy repo with it?

@Minuga-RC
Copy link
Contributor Author

our fault. Its the month configuration code line. What is the connection with the proxy repo with it?

umm nothing proxy dont need access to the time or date

@itz-rj-here
Copy link
Contributor

Thats strange.

@Minuga-RC
Copy link
Contributor Author

@itz-rj-here can u check if the same error appears in the main version?

@itz-rj-here
Copy link
Contributor

yup. just a min.

@itz-rj-here

This comment was marked as off-topic.

@Minuga-RC
Copy link
Contributor Author

image Same. It took some time to show me the errors.

I did installed the main version and I got the error too
image

@itz-rj-here
Copy link
Contributor

I'm thinking to take some help from chatgpt. Cause none of us is understanding the issue. 😂

@Minuga-RC
Copy link
Contributor Author

I don't think this is my fault

@Minuga-RC
Copy link
Contributor Author

anyway does the search suggestions works to you without a proxy? @itz-rj-here

@itz-rj-here
Copy link
Contributor

I can understand.
Let me real check it with gpt.

@itz-rj-here
Copy link
Contributor

I actually do not use proxy much but i can check it real quick.

@Minuga-RC
Copy link
Contributor Author

yea you can enable Search Suggestions in settings

@itz-rj-here

This comment was marked as off-topic.

@Minuga-RC
Copy link
Contributor Author

Minuga-RC commented Oct 16, 2024

alr I will let u do that xd

@itz-rj-here
Copy link
Contributor

yup. :)

@itz-rj-here
Copy link
Contributor

image image image It's better to use english only. -_-

Forget it its not even your work.

https://screenrec.com/share/IOVL2pgeEN

do this one.

@Minuga-RC
Copy link
Contributor Author

https://screenrec.com/share/IOVL2pgeEN

oh I can fix that

@itz-rj-here
Copy link
Contributor

I didnt do the translation fyi

@MestreWalla did it if im not wrong.
He forgot about these.

@itz-rj-here
Copy link
Contributor

Yup found it. #48

@itz-rj-here
Copy link
Contributor

You are doing the coding thingy and I'm testing your code thingy. Also eating and doing my assignment. :)

@Minuga-RC
Copy link
Contributor Author

You are doing the coding thingy and I'm testing your code thingy. Also eating and doing my assignment. :)

I just finished eating thats why I took some time to reply lol

@Minuga-RC
Copy link
Contributor Author

@itz-rj-here fixed the issue

@itz-rj-here
Copy link
Contributor

@itz-rj-here fixed the issue

Great work @Minuga-RC. You should rest now, you did a lot of work for 2-3 days. I will not disturb you now. As everything is fixed. Thanks for the contributions.

Copy link
Contributor

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now need to List all the changes where made here.

@MestreWalla
Copy link
Contributor

I made the translation system, but I didn't understand this language, if the Google buttons and others also have to be translated into some languages, I can implement the translation for them, but I'll let you insert the translation so I only understand English and Portuguese, I can't know if Google translated it correctly.

@itz-rj-here
Copy link
Contributor

Added search suggestions with proxy to bypass CORS errors (user can host their own proxy).
Added an option to disable/enable search suggestions and proxy; also added a disclaimer message on the first start.
A reset button was added to the menu section.
Fixed an issue with the double tap to edit not saving. #62
Added Brave Search engine and Made Google search engine as a default search engine. #14
The unfoldshortcut button (arrow in AI tools) fixed. #67
Buttons on fixed themes are not clickable. #58
A UI problem was resolved in the search box. #66

@itz-rj-here
Copy link
Contributor

itz-rj-here commented Oct 17, 2024

I made the translation system, but I didn't understand this language, if the Google buttons and others also have to be translated into some languages, I can implement the translation for them, but I'll let you insert the translation so I only understand English and Portuguese, I can't know if Google translated it correctly.

I understand. It can be translated into other languages, actually. It's like changing the language, but the sound of the translated Google name will be the same as the English Google name. 
Some untranslated sections like the AI tools chatgpt, Gemini, etc. 
The month and the day names. Like in the extension, we only see the short form of the days name and month name. But as we use the full names of the days and months, the translated days and months names come in half words, and the other half can't be shown. 
The English numbers. It can be translated in other languages too.
The location name. At least make it to change the only word to be translated.

Thats all. @MestreWalla.

@itz-rj-here
Copy link
Contributor

We will talk about the translation thing in the #68.
Keep this pr clean for now.

@itz-rj-here
Copy link
Contributor

@XengShi Requesting for review.

@Minuga-RC
Copy link
Contributor Author

@itz-rj-here I removed a not used style

@itz-rj-here
Copy link
Contributor

@itz-rj-here I removed a not used style

Hmm. This thing is not being used. Great. 3 Lines of code is being cleaned up. 😂

@itz-rj-here
Copy link
Contributor

itz-rj-here commented Oct 17, 2024

Some times I think that XengShi is a baby boss. 😂
But he is a baby king. :)

@Minuga-RC
Copy link
Contributor Author

lol

@Minuga-RC
Copy link
Contributor Author

Minuga-RC commented Oct 17, 2024

@XengShi is there is anything else that I can add/change?
im gonna go sleep now

@XengShi
Copy link
Owner

XengShi commented Oct 17, 2024

Excellent work, @Minuga-RC! Much love to you ♥. However, the issue persists, similar to the one we had with dark mode earlier. The proxy warning appears with every reload. Kindly fix that as well. The warning or disclaimer should only appear on the first load of the extension or after resetting the extension settings.

@XengShi XengShi merged commit f4f81ac into XengShi:main Oct 17, 2024
@XengShi
Copy link
Owner

XengShi commented Oct 17, 2024

image image image It's better to use english only. -_-

The person who could reach this extension should have basic knowledge of English ☺😊, but your points are valid.

@Minuga-RC
Copy link
Contributor Author

Excellent work, @Minuga-RC! Much love to you ♥. However, the issue persists, similar to the one we had with dark mode earlier. The proxy warning appears with every reload. Kindly fix that as well. The warning or disclaimer should only appear on the first load of the extension or after resetting the extension settings.

Umm it does only appear in the first load tho I made it like that

@XengShi
Copy link
Owner

XengShi commented Oct 17, 2024

Excellent work, @Minuga-RC! Much love to you ♥. However, the issue persists, similar to the one we had with dark mode earlier. The proxy warning appears with every reload. Kindly fix that as well. The warning or disclaimer should only appear on the first load of the extension or after resetting the extension settings.

Umm it does only appear in the first load tho I made it like that

In [Chrome on Windows] it appears everytime after reloading or opening newTab but in Firefox it is working fine, strange!

@itz-rj-here
Copy link
Contributor

Excellent work, @Minuga-RC! Much love to you ♥. However, the issue persists, similar to the one we had with dark mode earlier. The proxy warning appears with every reload. Kindly fix that as well. The warning or disclaimer should only appear on the first load of the extension or after resetting the extension settings.

Umm it does only appear in the first load tho I made it like that

In [Chrome on Windows] it appears everytime after reloading or opening newTab but in Firefox it is working fine, strange!

Wait, i didn’t see that issue. Only when i reset the settings and first load the settings it shows. But it doesn’t show on every single load.

@Minuga-RC
Copy link
Contributor Author

@XengShi so you need to press Ok to the alert so it records it in the local storage
image
then it will wont come up again

@XengShi
Copy link
Owner

XengShi commented Oct 18, 2024

@XengShi so you need to press Ok to the alert so it records it in the local storage image then it will wont come up again

Yeah, it's working fine. I was just clicking outside the dialog. Thanks for responding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants