Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Interruptable cursor based NPC name targeting #538

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Feature: Interruptable cursor based NPC name targeting #538

merged 2 commits into from
Sep 15, 2023

Conversation

Xian55
Copy link
Owner

@Xian55 Xian55 commented Sep 15, 2023 •
edited
Loading

Changes:

  • Added NamePlate detection

Fix:

  • Annoying issue while way too many NPC name detected on the screen and the search taking too long, it can be interrupted by pressing ESC button. While the GameMenu window is shown all mouse based search going to be interrupted!

Without NamePlate detection
npcnamefinder_nameplate

With Nameplate detection combined with NPC name(enemy plus neutral)
npcnamefinder_npcname_combined_with_nameplate

@Xian55
Core: NpcNameTargeting: While searching for the target cursor, can be…
dde5d43 
… interrupted with pressing ESC button press while the GameMenu is shown.
@Xian55
SharedLib: NpcNameFinder: Added NamePlate type detection. Looking for…
d3304e0 
… white and yellow pixels
@Xian55 Xian55 added bugfix This pull request fixes an issue. refactor This ticket concerns the possible simplification of code/data. enhancement This pull request implements a new feature. labels Sep 15, 2023
@Xian55 Xian55 merged commit bcd7f12 into dev Sep 15, 2023
@Xian55 Xian55 deleted the feature/interruptable-cursor-based-npc-name-targeting branch September 15, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This pull request fixes an issue. enhancement This pull request implements a new feature. refactor This ticket concerns the possible simplification of code/data.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Xian55