Fix (equalize): dtype fix in activation equalization #1217
Merged
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giuseppe5
reviewed
Mar 11, 2025
src/brevitas/nn/quant_scale_bias.py
Outdated
| @@ -31,9 +31,10 @@ def __init__(self, num_features: int, bias: bool, runtime_shape=(1, -1, 1, 1)): | |||
| self.runtime_shape = runtime_shape | |||
|
|
|||
| def forward(self, input): | |||
| out = input * self.weight.view(self.runtime_shape) | |||
| dtype = input.dtype | |||
| out = input * self.weight.view(self.runtime_shape).to(dtype=dtype) | |||
There was a problem hiding this comment.
Is there any way we can avoid casting on on the fly?
Also we cannot do this with to.('cuda') because that is definitely costly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Activation equalization crashes when using
bfloat16.Changes Made in this PR
Make
ScaleBiasoutput match the dtype of the input tensor.Testing Summary
Expanded tests for activation equalization with
float16andbfloat16.Risk Highlight
Checklist
devbranch.