Fix G_TRUNC assert in S20Narrowing #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinay-anubola
requested review from
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
gbossu
reviewed
Nov 19, 2024
gbossu
reviewed
Nov 19, 2024
abhinay-anubola
force-pushed
the
sanubola.fix.s20.narrowing.assert
branch
from
4e2b076 to
efd72f5
Compare
abhinay-anubola
force-pushed
the
sanubola.fix.s20.narrowing.assert
branch
from
efd72f5 to
76767ce
Compare
gbossu
approved these changes
Nov 19, 2024
andcarminati
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assert is causing a crash in the code. To prevent this, disabling the S20 narrowing by returning false when the corresponding case occurs.