-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCE] Ensure reserved simplifiable registers are live across call boundaries. #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagarMaheshwari99
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong and
stephenneuendorffer
as code owners
November 21, 2024 16:15
gbossu
reviewed
Nov 21, 2024
gbossu
reviewed
Nov 21, 2024
SagarMaheshwari99
force-pushed
the
sagarm.live.regs
branch
2 times, most recently
from
November 22, 2024 08:31
b1ce28e
to
47cacb4
Compare
gbossu
reviewed
Nov 22, 2024
SagarMaheshwari99
force-pushed
the
sagarm.live.regs
branch
from
November 22, 2024 10:10
47cacb4
to
fc0d393
Compare
gbossu
reviewed
Nov 25, 2024
…across call boundaries.
SagarMaheshwari99
force-pushed
the
sagarm.live.regs
branch
from
November 25, 2024 08:39
fc0d393
to
38c77c8
Compare
SagarMaheshwari99
force-pushed
the
sagarm.live.regs
branch
from
November 25, 2024 14:36
38c77c8
to
d7831da
Compare
gbossu
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
martien-de-jong
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.