Run code formatter on PRs targeting feature/fused-ops #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cferry-AMD
force-pushed
the
corentin.fix_code_formatter_ref
branch
from
6619215 to
fa5b770
Compare
cferry-AMD
changed the title
|
Do you know of users whose workflow would be broken by adding this check locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the code checking step from merging to
mainto PRs targetingfeature/fused-ops. Since we're usingfeature/fused-opsas our main branch in this repo, we'll check code formatting of PRs that targetfeature/fused-opsinstead ofmain.This PR will fix the issue we're currently having with CI (failing code formatting step after merging into
feature/fused-ops): since ourmainis late with respect to LLVM's, the script's version inmainis too old and is missing one argument that our branchfeature/fused-opswants.