Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FXML-4791] Lower memref expand/collapse to EmitC #313

Merged
merged 36 commits into from
Sep 9, 2024

Conversation

cferry-AMD
Copy link
Collaborator

No description provided.

@cferry-AMD
Copy link
Collaborator Author

cferry-AMD commented Aug 27, 2024

Requires proper inter-array-type casting with aliasing, for instance through reference support. Holding on for the moment.
Done

@cferry-AMD cferry-AMD force-pushed the corentin.memref_expand_collapse branch from 060eb25 to 14e8317 Compare August 28, 2024 15:43
@cferry-AMD cferry-AMD force-pushed the corentin.memref_expand_collapse branch from 14e8317 to 3d9b280 Compare August 28, 2024 15:47
@cferry-AMD cferry-AMD marked this pull request as ready for review August 29, 2024 08:09
@cferry-AMD cferry-AMD changed the base branch from feature/fused-ops to corentin.references August 29, 2024 08:10
Copy link
Collaborator

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cferry-AMD
Copy link
Collaborator Author

@TinaAMD, this is also ready for review along with #316 :)

Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mlir/test/Dialect/EmitC/invalid_ops.mlir Show resolved Hide resolved
Base automatically changed from corentin.references to feature/fused-ops September 9, 2024 07:01
@cferry-AMD cferry-AMD enabled auto-merge (squash) September 9, 2024 07:04
@cferry-AMD cferry-AMD merged commit dfb5921 into feature/fused-ops Sep 9, 2024
4 checks passed
@cferry-AMD cferry-AMD deleted the corentin.memref_expand_collapse branch September 9, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants