forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FXML-4791] Lower memref expand/collapse to EmitC #313
Merged
cferry-AMD
merged 36 commits into
feature/fused-ops
from
corentin.memref_expand_collapse
Sep 9, 2024
Merged
[FXML-4791] Lower memref expand/collapse to EmitC #313
cferry-AMD
merged 36 commits into
feature/fused-ops
from
corentin.memref_expand_collapse
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cferry-AMD
force-pushed
the
corentin.memref_expand_collapse
branch
from
August 28, 2024 15:43
060eb25
to
14e8317
Compare
cferry-AMD
force-pushed
the
corentin.memref_expand_collapse
branch
from
August 28, 2024 15:47
14e8317
to
3d9b280
Compare
cferry-AMD
changed the base branch from
feature/fused-ops
to
corentin.references
August 29, 2024 08:10
cferry-AMD
commented
Sep 2, 2024
mgehre-amd
reviewed
Sep 3, 2024
mgehre-amd
reviewed
Sep 3, 2024
mgehre-amd
reviewed
Sep 3, 2024
mgehre-amd
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
TinaAMD
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cferry-AMD
commented
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.