[AutoBump] Merge with fixes of a54efdbd (needs downstream update, Sep 11) (23) #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------- Motivation: ---------- Spec conformance. Allows assumptions to be made in TOSA code. ------------ Changes Made: ------------ Add full permutation tensor verification to tosa.TRANSPOSE. Priorly would not verify that permuted values were between 0 - (rank - 1). Update tosa.TRANSPOSE perms data type to be strictly i32. Verify input/output shapes for tosa.TRANSPOSE. Add verifier to tosa.CONST, with consideration for quantization. Fix TOSA conformance of tensor type to disallow dimensions with size 0 for ranked tensors, per spec. This is not the same as rank 0 tensors. Here is an example of a disallowed tensor: tensor<3x0xi32>. Naturally, this means that the number of elements in a TOSA tensor will always be greater than 0. Signed-off-by: Arteen Abrishami <[email protected]>
mgehre-amd
force-pushed
the
bump_to_a54efdbd
branch
from
5a89407 to
1452055
Compare
mgehre-amd
changed the title
cferry-AMD
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the perm argument of tosa.transpose to be i32, where previously i32 and i64 was allowed. Causes breakage downstream.
Required changes are in downstream PR 13813.