Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include comments with template argument names in Cpp code from EmitC #403

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Include comments with template argument names in Cpp code from EmitC #403

merged 4 commits into from
Nov 27, 2024

Conversation

lmendesp-amd
Copy link
Collaborator

No description provided.

cferry-AMD
cferry-AMD approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@cferry-AMD cferry-AMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mlir/lib/Target/Cpp/TranslateToCpp.cpp Outdated Show resolved Hide resolved
@mgehre-amd
Copy link
Collaborator

Thank you! I added a small comments, but looks good overall.

@lmendesp-amd lmendesp-amd merged commit e25d207 into feature/fused-ops Nov 27, 2024
4 checks passed
@lmendesp-amd lmendesp-amd deleted the lmendesp.emit-template-arg-names-in-cpp branch November 27, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cferry-AMD cferry-AMD cferry-AMD approved these changes

@mgehre-amd mgehre-amd mgehre-amd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmendesp-amd @mgehre-amd @cferry-AMD