Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOSA: add folder for tosa.sub #72

Merged
merged 4 commits into from
Aug 16, 2023
Merged

TOSA: add folder for tosa.sub #72

merged 4 commits into from
Aug 16, 2023

Conversation

mgehre-amd
Copy link
Collaborator

This is essentially a copy of the tosa.add folder

TinaAMD
TinaAMD requested changes Aug 11, 2023
View reviewed changes
Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add some tests for the new sub folder?

mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Show resolved Hide resolved
mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
TinaAMD
TinaAMD approved these changes Aug 16, 2023
View reviewed changes
Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgehre-amd mgehre-amd enabled auto-merge (squash) August 16, 2023 13:32
@mgehre-amd mgehre-amd merged commit cc3af09 into feature/fused-ops Aug 16, 2023
1 check passed
@mgehre-amd mgehre-amd deleted the matthias.tosa_sub_folder branch August 16, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaAMD TinaAMD TinaAMD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgehre-amd @TinaAMD