Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix topological sort use #1945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix topological sort use #1945

wants to merge 1 commit into from
+5 −10

Conversation

keryell
Copy link
Member

@keryell keryell commented Nov 25, 2024

Probably this code was never exercised since the API was wrongly used (topologicalSort does not mutate its parameter) and it was probably not the right function at the first place.

@keryell
Fix topological sort use
28fa2c3 
Probably this code was never exercised since the API was wrongly
used (topologicalSort does not mutate its parameter) and it was probably not the
right function at the first place.
@keryell
Copy link
Member Author

keryell commented Nov 25, 2024

This caused me quite some debug time since I took this code as a word of truth in https://github.com/Xilinx/mlir-aie/pull/1913/files#diff-9a9c67284c8006f81d3dcfb1e27c01b2de924a2d5d41f27c9fd640af38fe5a0bR88 😺

AndraBisca
AndraBisca approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@AndraBisca AndraBisca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix Ronan! :)

jgmelber
jgmelber reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@jgmelber jgmelber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test case you can provide for this?

@keryell
Copy link
Member Author

keryell commented Dec 2, 2024

Is there a test case you can provide for this?

No, since I do not use this code here, this is just an educated guess with my fix.
It looks like @makslevental wrote this last year
abbcb9a lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp (Maksim Levental) 2023-11-29
abbcb9a#diff-9b64fc073f494cbde2d58fb41a69634d2cbb29b6b5430216c16649c000b7250a
so perhaps he could comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgmelber jgmelber jgmelber left review comments

@AndraBisca AndraBisca AndraBisca approved these changes

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

@fifield fifield Awaiting requested review from fifield fifield is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keryell @jgmelber @AndraBisca