TorchToTosa: Emit tosa.matmul with legal types #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. bf16xbf16 -> f32
roberteg16
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Thanks! I find weird that no test fails?
This is the PR that introduce the conformity to TOSA. Did we loose those test on the bump? #146
Base automatically changed from
matthias.bump_torch_mlir5
to
feature/backport_ea1_ops
April 25, 2024 12:34
mgehre-amd
changed the base branch from
feature/backport_ea1_ops
to
matthias.fix_submodule
I'm porting over the tests now |
mgehre-amd
force-pushed
the
matthias.tosa_matmul
branch
from
fa98638 to
8599f4f
Compare
Base automatically changed from
matthias.fix_submodule
to
feature/backport_ea1_ops
May 10, 2024 12:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. bf16xbf16 -> f32
This restores functionality we had lost with the last bump.