[AutoBump] Merge with fixes of 11cd7cd9 (23) #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l2dWithIndicesOp (llvm#3272) While playing with TorchDynamo on ResNet18. I notice following issues: - `prims.convert_element_type` can’t be canonicalized even if the input and the output share the same type - `aten.max_pool2d_with_indices` is always used instead of `aten.max_pool2d`, even if the second returned output (indices) has no user This PR fixes above issues by adding a folder to the PrimsConvertElementTypeOp and a canonicalizer to the AtenMaxPool2dWithIndicesOp Lit test: `cmake --build build --target check-torch-mlir-all` --------- Co-authored-by: Ze Zhang <[email protected]>
cferry-AMD
approved these changes
Aug 22, 2024
An error occurred while trying to automatically change base from
bump_to_8c48135a
to
feature/backport_ea1_ops
August 23, 2024 16:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.