Update tests to match changed op order #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorickert
commented
Dec 13, 2024
| // CHECK: tm_tensor.scan dimension(0) inclusive(true) ins(%[[IN_MEMREF]] : memref<128xi32>) | ||
| // CHECK-SAME: outs(%[[OUT_MEMREF_NEW]], %[[ACC_MEMREF_NEW]] : memref<128xi32>, memref<i32>) { | ||
| // CHECK: ^bb0(%[[OUT_PREV_ELEMENT:.*]]: i32, %[[IN_ELEMENT:.*]]: i32): | ||
| // CHECK: %[[OUT_CURRENT_ELEMENT:.*]] = arith.addi %[[OUT_PREV_ELEMENT]], %[[IN_ELEMENT]] : i32 | ||
| // CHECK: tm_tensor.yield %[[OUT_CURRENT_ELEMENT]] : i32 | ||
| // CHECK: } | ||
| // CHECK-DAG: %[[OUT_TENSOR_NEW:.*]] = bufferization.to_tensor %[[OUT_MEMREF_NEW]] : memref<128xi32> |
There was a problem hiding this comment.
Can someone confirm that moving this above the last use of the memref is valid?
There was a problem hiding this comment.
Looks odd. Is this how the reference look upstream? They have a bump to that LLVM version, right?
Maybe we want to wait until I catched up with torch-mlir bumps?
There was a problem hiding this comment.
Yes, upstream they have the same reference for some of the tests: https://github.com/llvm/torch-mlir/blob/8e0eafd022cd7555c8b58927d3238a7a89e9dbd4/test/Dialect/TMTensor/bufferize.mlir#L10 . I agree that we should try to get to llvm#3765 in torch-mlir .
|
Superseeded by #435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for: Xilinx/llvm-project#424