Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asan: replace used python in various lit.cfg's with shim script #449

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

philippjh
Copy link
Member

This PR exchanges the used Python executable inside various test suites, when a IS_ASAN environment variable is present on Linux hosts. The behavior and achieved benefits are similar to what is happening inside Xilinx/llvm-project#436.

@philippjh
Copy link
Member Author

@mgehre-amd I'm curious, whether we can detect ASan configurations by inspecting config.available_features just like in the LLVM PR I've linked above, instead of (manually) having IS_ASAN present in the environment.

@mgehre-amd
Copy link
Collaborator

@mgehre-amd I'm curious, whether we can detect ASan configurations by inspecting config.available_features just like in the LLVM PR I've linked above, instead of (manually) having IS_ASAN present in the environment.

I think it should work. torch-mlir is also using LLVM for the lit setup, and LLVM contains the generic code to set the features (here: https://github.com/llvm/llvm-project/blob/df728cf1d7959e214af68dbf4d6e3750fc7b5b13/llvm/utils/lit/lit/llvm/config.py#L125)
Can you try?

@philippjh
Copy link
Member Author

I think it should work. torch-mlir is also using LLVM for the lit setup, and LLVM contains the generic code to set the features (here: https://github.com/llvm/llvm-project/blob/df728cf1d7959e214af68dbf4d6e3750fc7b5b13/llvm/utils/lit/lit/llvm/config.py#L125) Can you try?

Thank you for the pointer, I will give that a try.

@philippjh philippjh force-pushed the philippjh.fix-asan-lit branch from f04047a to f5abc54 Compare January 6, 2025 21:30
@philippjh philippjh merged commit ec50da7 into feature/backport_ea1_ops Jan 7, 2025
4 checks passed
@philippjh philippjh deleted the philippjh.fix-asan-lit branch January 7, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants