Increate timeout to 1 min for testnet #746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: reduce mine period reset (waiting) time * fix: reset time negative problem * fix: too many time reset=0, and change log level * update log format --------- Co-authored-by: liam.lai <liam.lai@us>
increate timeout to 1 min for testnet fix test and update log level
benjamin202410
force-pushed
the
increate-timeout-to-1-min-for-testnet
branch
from
b5ca27b
to
ce9bc9f
Compare
gzliudan
reviewed
Nov 25, 2024
| @@ -302,12 +304,14 @@ func (w *worker) update() { | |||
| if atomic.LoadInt32(&w.mining) == 1 { | |||
| w.commitNewWork() | |||
| } | |||
| timeout.Reset(time.Duration(minePeriod) * time.Second) | |||
| resetTime := getResetTime(w.chain, minePeriod, &prevReset0TimeMillisec) | |||
| timeout.Reset(resetTime) | |||
There was a problem hiding this comment.
Reset should always be invoked on stopped or expired channels
gzliudan
reviewed
Nov 25, 2024
|
|
||
| // Handle ChainHeadEvent | ||
| case <-w.chainHeadCh: | ||
| w.commitNewWork() | ||
| timeout.Reset(time.Duration(minePeriod) * time.Second) | ||
| resetTime := getResetTime(w.chain, minePeriod, &prevReset0TimeMillisec) | ||
| timeout.Reset(resetTime) |
There was a problem hiding this comment.
Reset should be invoked only on stopped or expired timers with drained channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge from master branch with mining time fix and vote fix
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that