-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add script for subnet deployment #171
base: master
Are you sure you want to change the base?
Conversation
please use a tool to format shell files |
e4afbf3
to
0ddf50b
Compare
OS_TYPE=$(uname) | ||
|
||
# Function to handle grep on macOS and Linux differently | ||
grep_command() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing the function
keyword
} | ||
|
||
# Function to handle sed on macOS and Linux differently | ||
sed_command() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing the function
keyword
|
||
set -eo pipefail | ||
|
||
FILE="../docker-compose.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to also use cd "$(dirname "$0")"
to make script able to run from any directory
# New subnet configuration content | ||
NEW_SUBNET="\ | ||
subnet$NEW_SUBNET_ID: | ||
image: xinfinorg/xdcsubnets:v0.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't hardcode the image version
@@ -0,0 +1,105 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer add-node.sh
filename to be inline with other scritps
This PR adds the script file
add_node.sh
which adds node to subnet.