Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeJS-less formatting script #332

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

CorbinWunderlich
Copy link
Contributor

@CorbinWunderlich CorbinWunderlich commented Nov 28, 2024

JS-beautify is a non-intrusive formatting solution, that is fairly configurable and has reasonable formatting choices (though it is preference). This PR deletes NodeJS, and adds a format.sh script for formatting the files and installing nix in one. Solves the complaints about formatting in #306. The shell.nix fetches the newest stable version of nixpkgs at the time (24.05, though 24.11 is coming soon), to add enough consistency and version pinning since I believe that a flake is too complex for such a simple task.

This PR does not format the files with this new formatter, but instead just adds the formatter.

@CorbinWunderlich CorbinWunderlich mentioned this pull request Nov 28, 2024
4 tasks
@totaam
Copy link
Collaborator

totaam commented Nov 28, 2024

lib should be left untouched as these files are updated in-place from their respective upstreams.

@CorbinWunderlich
Copy link
Contributor Author

lib should be left untouched as these files are updated in-place from their respective upstreams.

Done

@totaam totaam merged commit df5235d into Xpra-org:master Nov 28, 2024
1 check passed
@CorbinWunderlich
Copy link
Contributor Author

@totaam Wow, that was fast. If you want, you can run the formatter and commit the changes.

@totaam
Copy link
Collaborator

totaam commented Nov 28, 2024

Whoohoo - it's finally gone.

@sbradnick this will be music to your ears.

@CorbinWunderlich
Copy link
Contributor Author

Whoohoo - it's finally gone.

@sbradnick this will be music to your ears.

I realized I forgot to delete the .husky directory. I could do that or you could quickly do that. Very minor, sorry for my mistake

@CorbinWunderlich
Copy link
Contributor Author

As another thing, if you try to commit, you might get a husky error because the git hooks still exist (unfortunately). Delete the .git/hooks directory, then run git init to reinitialize the default git hooks

@CorbinWunderlich
Copy link
Contributor Author

Whoohoo - it's finally gone.
@sbradnick this will be music to your ears.

I realized I forgot to delete the .husky directory. I could do that or you could quickly do that. Very minor, sorry for my mistake

#333

@totaam
Copy link
Collaborator

totaam commented Nov 28, 2024

No problem at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants