Make the float menu list and window list open up or down depending on position #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… position If the float menu's position is in the upper half of the screen, it will open downwards, and vice versa
CorbinWunderlich
force-pushed
the
start-menu-change-direction
branch
from
486838d to
1685792
Compare
|
Thanks! |
|
@CorbinWunderlich BTW, I have created a new branch with all these changes: |
That works for me. I didn't even make the important changes for this release, so it doesn't really matter for me. I would just say to look over authentication on the html5 client, as I have had some issues with insecure digests on master (it seems to use xor instead of hmac on passwordfile). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the float menu is positioned in the bottom part of the screen, the dropdowns cannot be seen or interacted with. This solves that by making the menus open up or down depending on the position of the float menu. If the float menu is on the bottom half of the screen, it will open upwards, and vice versa.