Skip to content

Commit

Permalink
fixup 79f1837 backport: errors with Xvfb
Browse files Browse the repository at this point in the history
  • Loading branch information
@totaam
totaam committed Dec 17, 2023
1 parent a9441fb commit 30c7cfa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xpra/x11/x11_server_core.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,7 @@ def set_screen_size(self, desired_w:int, desired_h:int, bigger:bool=True):
screenlog("using XRRSetScreenConfigAndRate with %ix%i", w, h)
with xsync:
RandR.set_screen_size(w, h)
if RandR.check_randr():
if RandR.check_randr_sizes():
#Xvfb with randr > 1.2
#we can use XRRSetScreenSize:
try:
Expand Down

1 comment on commit 30c7cfa

@cpatulea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, thanks for this fix. Took a while to track it down and was preparing to send my own PR.

For reference, here's the error that I was getting before this fix (at v5.0.4):

    2023-12-30 21:17:45,865 ouch, failed to set new resolution: 'xpra.x11.bindings.randr.RandRBindingsInstance' object has no attribute 'check_rand>
    Traceback (most recent call last):
      File "/home/catalinp/.local/lib/python3.9/site-packages/xpra/x11/x11_server_core.py", line 779, in set_screen_size
        if RandR.check_randr():
    AttributeError: 'xpra.x11.bindings.randr.RandRBindingsInstance' object has no attribute 'check_randr'

Please sign in to comment.