refactor: List -> Set으로 자료형 변경 (#201)

YAPP-Github · Jul 13, 2024 · 1d3fbd4 · 1d3fbd4
1 parent 4457d39
commit 1d3fbd4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/batch/src/main/kotlin/com/few/batch/service/article/dto/WorkBookSubscriberItem.kt b/batch/src/main/kotlin/com/few/batch/service/article/dto/WorkBookSubscriberItem.kt
@@ -1,11 +1,11 @@
 package com.few.batch.service.article.dto
 
-fun List<WorkBookSubscriberItem>.toMemberIds(): List<Long> {
-    return this.map { it.memberId }
+fun List<WorkBookSubscriberItem>.toMemberIds(): Set<Long> {
+    return this.map { it.memberId }.toSet()
 }
 
-fun List<WorkBookSubscriberItem>.toTargetWorkBookIds(): List<Long> {
-    return this.map { it.targetWorkBookId }
+fun List<WorkBookSubscriberItem>.toTargetWorkBookIds(): Set<Long> {
+    return this.map { it.targetWorkBookId }.toSet()
 }
 
 /** key: 구독자들이 구독한 학습지 ID, value: 구독자들의 학습지 구독 진행률 */

diff --git a/batch/src/main/kotlin/com/few/batch/service/article/writer/WorkBookSubscriberWriter.kt b/batch/src/main/kotlin/com/few/batch/service/article/writer/WorkBookSubscriberWriter.kt
@@ -129,6 +129,7 @@ class WorkBookSubscriberWriter(
             .and(articleIfoT.DELETED_AT.isNull)
             .fetchInto(ArticleContent::class.java)
 
+        // todo fix
         val memberSuccessRecords = memberIds.associateWith { true }.toMutableMap()
         val failRecords = mutableMapOf<String, ArrayList<Map<Long, String>>>()
         // todo check !! target is not null