#55 feat: GET /api/v1/workbooks/{workbookId} 구현 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hun-ca
approved these changes
Jun 24, 2024
Comment on lines
71
to
88
| return dslContext.select( | ||
| ArticleMst.ARTICLE_MST.ID.`as`(SelectWorkBookArticleRecord::articleId.name), | ||
| ArticleMst.ARTICLE_MST.MEMBER_ID.`as`(SelectWorkBookArticleRecord::writerId.name), | ||
| ArticleMst.ARTICLE_MST.MAIN_IMAGE_URL.`as`(SelectWorkBookArticleRecord::mainImageURL.name), | ||
| ArticleMst.ARTICLE_MST.TITLE.`as`(SelectWorkBookArticleRecord::title.name), | ||
| ArticleMst.ARTICLE_MST.CATEGORY_CD.`as`(SelectWorkBookArticleRecord::category.name), | ||
| ArticleIfo.ARTICLE_IFO.CONTENT.`as`(SelectWorkBookArticleRecord::content.name), | ||
| ArticleMst.ARTICLE_MST.CREATED_AT.`as`(SelectWorkBookArticleRecord::createdAt.name), | ||
| MappingWorkbookArticle.MAPPING_WORKBOOK_ARTICLE.DAY_COL.`as`(SelectWorkBookArticleRecord::day.name) | ||
| ) | ||
| .from(MappingWorkbookArticle.MAPPING_WORKBOOK_ARTICLE) | ||
| .leftJoin(ArticleMst.ARTICLE_MST) | ||
| .on(MappingWorkbookArticle.MAPPING_WORKBOOK_ARTICLE.ARTICLE_ID.eq(ArticleMst.ARTICLE_MST.ID)) | ||
| .leftJoin(ArticleIfo.ARTICLE_IFO) | ||
| .on(ArticleMst.ARTICLE_MST.ID.eq(ArticleIfo.ARTICLE_IFO.ARTICLE_MST_ID)) | ||
| .where(MappingWorkbookArticle.MAPPING_WORKBOOK_ARTICLE.WORKBOOK_ID.eq(workbookId)) | ||
| .fetchInto(SelectWorkBookMappedArticleRecord::class.java) | ||
| } |
There was a problem hiding this comment.
SQL로 변환해서 보면,,,
SELECT
article_mst.id AS articleId,
article_mst.member_id AS writerId,
article_mst.main_image_url AS mainImageURL,
article_mst.title AS title,
article_mst.category_cd AS category,
article_ifo.content AS content,
article_mst.created_at AS createdAt,
mapping_workbook_article.day_col AS day
FROM
mapping_workbook_article
LEFT JOIN
article_mst
ON mapping_workbook_article.article_id = article_mst.id
LEFT JOIN
article_ifo
ON article_mst.id = article_ifo.article_mst_id
WHERE
mapping_workbook_article.workbook_id = :workbookId;
아티클mst에 row가 있다는건 아티클info에서도 row가 있다는건데 Left join을 꼭 해야할까요? 그냥 조인으로 가도 결과 똑같을듯
There was a problem hiding this comment.
join으로 해도 결과가 동일하네요! 감사함다!!
| ) | ||
| .from(Member.MEMBER) | ||
| .where(Member.MEMBER.ID.`in`(query.writerIds)) | ||
| .and(Member.MEMBER.TYPE_CD.eq(1)) // todo fix after considering the type_cd |
There was a problem hiding this comment.
MemberType 제가 만들어둔걸로 ㄱ ㄱ (직접숫자 넣기X)
| Workbook.WORKBOOK.CREATED_AT.`as`(SelectWorkBookRecord::createdAt.name) | ||
| ) | ||
| .from(Workbook.WORKBOOK) | ||
| .where(Workbook.WORKBOOK.ID.eq(query.id)) |
Comment on lines
8
to
21
| val mainImageUrl: String, | ||
| val title: String, | ||
| val description: String, | ||
| val category: String, | ||
| val createdAt: LocalDateTime, | ||
| val writers: List<WriterDetail>, | ||
| val articles: List<ArticleDetail> | ||
| ) | ||
|
|
||
| data class WriterDetail( | ||
| val id: Long, | ||
| val name: String, | ||
| val url: URL | ||
| ) |
There was a problem hiding this comment.
WriterDetail의 url 타입은 URL이고 ReadWorkbookUseCaseOut의 mainImageUrl 타입은 String인데 이렇게 된 이유가 뭔가요?
There was a problem hiding this comment.
제가 url을 dao에서 부터 String으로 가져오고 있더라고요..!
다른 url: String까지 한번에 고치겠습니다~! 감사합니다!
belljun3395
changed the title
# Conflicts: # api-repo/src/main/kotlin/com/few/api/repo/dao/member/MemberDao.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #55
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트