[Refactor/#143] 어드민 API 요구사항 반영 및 오류 수정 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
config
Closed
belljun3395
force-pushed
the
refactor/#143_belljun3395
branch
from
7f5053e to
6f23052
Compare
belljun3395
force-pushed
the
refactor/#143_belljun3395
branch
from
6f23052 to
fa01da5
Compare
hun-ca
approved these changes
Jul 7, 2024
Comment on lines
13
to
14
| val problemData: ProblemDetail | ||
| val problemData: List<ProblemDetail> |
There was a problem hiding this comment.
필드명이 복수형을 의미할 수 있도록 problems 등으로 수정되면 더 좋을거 같아요
Comment on lines
-21
to
+34
| private val problemDao: ProblemDao | ||
| private val problemDao: ProblemDao, | ||
| private val documentDao: DocumentDao, | ||
| private val convertDocumentService: ConvertDocumentService, | ||
| private val putDocumentService: PutDocumentService, | ||
| private val getUrlService: GetUrlService |
There was a problem hiding this comment.
서비스는 도메인 별로 하나만 두는걸로 변경 필요합니다(저희끼리 정했던 부분)
추가로 유즈케이스가 아티클쪽인데 member, problem은 DAO 바로 사용하시나요?
There was a problem hiding this comment.
여기는 어드민으라서 바로 dao로 사용했습니다!
|
domain 패키지가 web 패키지의 클래스를 알면 안된다고 생각하지만 |
|
#174 디스커션에 등록했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #142 #143
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
카테고리
📸 스크린샷
🤖 테스트 체크리스트