[#165/refactor]: article 배치 실행 api에 인증 추가 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hun-ca
approved these changes
Jul 7, 2024
Comment on lines
+20
to
+23
| fun batchArticle(@RequestParam(value = "auth") auth: String) { | ||
| if (this.auth != auth) { | ||
| throw IllegalAccessException("Invalid Permission") | ||
| } |
There was a problem hiding this comment.
query param은 일반적으로 GET 요청에서만 사용(조회할 데이터에 대한 상세 구분)하는 것이 일반적입니다. 헤더나 바디로 뺄 수. ㅣㅆ는지 검토필요해보입니다
There was a problem hiding this comment.
아 저도 동의합니다!
파람으로 해둔 것은 제가 아직 파이어베이스 function에 익숙하지 않아서 post 보다는 get으로 처리할 수 있는 방법으로 구현했어요!
There was a problem hiding this comment.
#171 에서 수정하겠습니다!
| level: | ||
| root: debug | ||
| auth: | ||
| batch: ${AUTH_BATCH:0518} |
There was a problem hiding this comment.
${AUTH_BATCH:0518} 이 필드는 어디서가져오나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #165
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트